how to choose the tense? (present perfect or past simple)
A
has the time period finished? (PP is used when the time period has not finished; PS is used when the time period has finished)
is it new or old information? (PP - recent news, PS - older information)
is it specific time? (PP - time is not specified, PS - time is clear)
has the action finished? (PP is used with for and since when the actions have not finished yet; PS is used with for when the actions have already finished)